Witness Lifting (Point Cloud to Simplicial)

pyt-team / challenge-icml-2024

Official repository for the Topological Deep Learning Challenge 2024, organized by TAG-DS & PyT-Team and hosted by GRaM Workshop @ ICML 2024.

https://pyt-team.github.io/packs/challenge.html

MIT License

37 stars 48 forks source link

Witness Lifting (Point Cloud to Simplicial) #20

Open Snopoff opened 2 months ago

Snopoff commented 2 months ago

This lifting implements lifting that constructs a simplicial complex, called Witness complex, from a point cloud. The Witness complex is computed using the GUDHI library [1]. In the current implementation the Witness complex is defined over a point cloud $W$, called witnesses. From this set, a subset $L$ of landmarks is formed by randomly choosing the points.

Current implementation can only lift to a weak Euclidian Witness complex:

weak means that $\sigma \in L$ is witnessed by $w\in W$ if $\forall l\in \sigma, \forall l' \in L: d(w,l)\leq d(w,l')$
euclidian means that the set of witnesses and landmarks are in Euclidian space.

output

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

levtelyatnikov commented 2 months ago

Please consider making the tests pass to make this submission valid for the challenge

gbg141 commented 2 months ago

Hello @Snopoff! Thank you for your submission. As we near the end of the challenge, I am collecting participant info for the purpose of selecting and announcing winners. Please email me (or have one member of your team email me) at guillermo_bernardez@ucsb.edu so I can share access to the voting form. In your email, please include:

your first and last name (as well as any other team members)
the title of the method you implemented
the input domain of the method you implemented
the output domain of the method you implemented
your pull request number (#20)

Before July 12, make sure that your submission respects all Submission Requirements laid out on the challenge page. Any submission that fails to meet this criteria will be automatically disqualified.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@497947b). Learn more about missing BASE report.

Files	Patch %	Lines
modules/data/utils/utils.py	87.50%	1 Missing :warning:
.../liftings/pointcloud2simplicial/witness_lifting.py	97.05%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #20 +/- ## ======================================= Coverage ? 68.21% ======================================= Files ? 18 Lines ? 538 Branches ? 0 ======================================= Hits ? 367 Misses ? 171 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.