pytask-dev / pytask-latex

Compile LaTeX documents with pytask.
MIT License
7 stars 1 forks source link

Implementation of build steps and support for old API #32

Closed axtimhaus closed 2 years ago

axtimhaus commented 2 years ago

Changes

Todo

tobiasraabe commented 2 years ago

Hi @axtimhaus, this looks awesome! Can I offer any help or are you just looking for some time to finish the implementation?

axtimhaus commented 2 years ago

If you would check up the tests I would be thankful ;) I'm going to build the other build steps soon.

codecov[bot] commented 2 years ago

Codecov Report

Merging #32 (56321d5) into main (a114ce1) will decrease coverage by 0.25%. The diff coverage is 98.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   98.85%   98.60%   -0.26%     
==========================================
  Files          14       17       +3     
  Lines         524      572      +48     
==========================================
+ Hits          518      564      +46     
- Misses          6        8       +2     
Flag Coverage Δ
end_to_end 92.83% <98.44%> (+4.47%) :arrow_up:
unit 59.61% <52.71%> (-7.37%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_collect.py 97.72% <ø> (-1.09%) :arrow_down:
src/pytask_latex/collect.py 97.67% <94.87%> (-2.33%) :arrow_down:
src/pytask_latex/compilation_steps.py 100.00% <100.00%> (ø)
src/pytask_latex/parametrize.py 100.00% <100.00%> (ø)
src/pytask_latex/path.py 100.00% <100.00%> (ø)
src/pytask_latex/utils.py 100.00% <100.00%> (ø)
tests/test_execute.py 100.00% <100.00%> (ø)
tests/test_parallel.py 97.46% <100.00%> (+1.10%) :arrow_up:
tests/test_parametrize.py 98.21% <100.00%> (+0.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a114ce1...56321d5. Read the comment docs.

tobiasraabe commented 2 years ago

Hi @axtimhaus,

I got the tests running and made some changes to the code. Here is some feedback:

axtimhaus commented 2 years ago

Hi @tobiasraabe,

yes, you are right, I lack a bit of discipline in that stuff... I often work with code that is not testable very well, so I have to get used to it. But I ran the tests after my changes, and all existing ones were passing. Maybe something went wrong, have to check this.

So could I get over to implement the other steps?

tobiasraabe commented 2 years ago

No problem. If you like you can move over implementing the other build steps.

I'll wrap up this PR probably on Monday and document the new interface.

tobiasraabe commented 2 years ago

Hi @axtimhaus, I finished the readme. Just one thing which might sound silly. If people want to abbreviate the import for the build steps, they might do from pytask_latex import build_steps as bs. You can call it a namespace collision. Would you be fine with renaming it to compilation_steps?