pytest-dev / apipkg

MIT License
55 stars 17 forks source link

Re-enable python 3.4 tests #31

Closed RonnyPfannschmidt closed 2 years ago

RonnyPfannschmidt commented 2 years ago

@RonnyPfannschmidt was the removal of 3.4 accidental? This caused https://github.com/pytest-dev/apipkg/issues/29 bug. It is still possible to test it if there's need. But only under ubuntu-18.04: https://github.com/actions/python-versions/blob/c483657/versions-manifest.json#L1228. Here's an example of such an inclusion: https://github.com/cherrypy/cheroot/commit/b332301ef0670445e67e9167697d437fdd385fc9#diff-207f09dfa0bc604a684631a1c78be7d9aa00f9a6c778eec30afa287990be3da1R32-R36.

_Originally posted by @webknjaz in https://github.com/pytest-dev/apipkg/pull/24#discussion_r756497649_

RonnyPfannschmidt commented 2 years ago

closing this one off as wontfix due to personal constraints and the general death of python 3.4

29 will be resolved however