pytest-dev / iniconfig

MIT License

53 stars 31 forks source link

Fix version autodetection from git tags #15

Closed florimondmanca closed 3 years ago

florimondmanca commented 3 years ago

Fixes #14 (provided a new release of this package to PyPI)

10 dropped the `setup_requires` option by moving build requirements to `pyproject.toml`. Sounds fair enough, but #10 also dropped `use_scm_version`, while the versioning strategy hasn't changed (at least, there's no explicit `version` option passed to `setup()`). So it looks like it was an oversight, and this PR adds the option back.

florimondmanca commented 3 years ago

Thanks @RonnyPfannschmidt :-)

Czaki commented 3 years ago

When next release?

RonnyPfannschmidt commented 3 years ago

after changelog

RonnyPfannschmidt commented 3 years ago

should be out after the pipeline finishes

florimondmanca commented 3 years ago

@RonnyPfannschmidt Can confirm the new 1.1.1 release got our CI pipelines succeeding again! Thanks a ton for jumping in so promptly. :-)

P.S.: @czaki Don't think that's how you meant it to come across, but I think at least a quick "thanks" to Ronny for going out of his way and cutting a new release to allow you and other folks' to fix up builds would have been a nice gesture. To avoid spreading a culture of entitlement in open source, small things like these matter. :+1:

Czaki commented 3 years ago

Sorry for my lack of culture. I was beetwen two meetings. Thanks for fast reaction and bugfix.