pytest-dev / meta

Used for generic pytest organization issues, stuff that can impact multiple projects.
https://docs.pytest.org/en/stable/contributing.html#
MIT License
2 stars 1 forks source link

Adoption of pytest-github-actions-annotate-failures plugin to pytest-dev organization #9

Open utgwkk opened 3 years ago

utgwkk commented 3 years ago

pytest-github-actions-annotate-failures is a pytest plugin to annotate failed tests with a workflow command for GitHub Actions.

I want to submit the repository to pytest-dev organization because @ssbarnea suggested (https://github.com/utgwkk/pytest-github-actions-annotate-failures/issues/33) and I also want to make the future of this plugin safer.

nicoddemus commented 3 years ago

Hi Utagawa,

Thanks for the submission.

+1 from me.

Cheers,

On Sun, Sep 12, 2021 at 11:18 AM utagawa kiki @.***> wrote:

pytest-github-actions-annotate-failures https://pypi.org/project/pytest-github-actions-annotate-failures/ is a pytest plugin to annotate failed tests with a workflow command for GitHub Actions https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions .

I want to submit the repository to pytest-dev organization because @ssbarnea https://github.com/ssbarnea suggested ( utgwkk/pytest-github-actions-annotate-failures#33 https://github.com/utgwkk/pytest-github-actions-annotate-failures/issues/33) and I also want to make the future of this plugin safer.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pytest-dev/meta/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAII57GHURW3DI2UIDS6PJ3UBSZEVANCNFSM5D4EUJ5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

utgwkk commented 3 years ago

Can I start to transfer the repository?

ssbarnea commented 1 year ago

@utgwkk @nicoddemus Any idea why this attempt got lost? I would find it very useful and will help maintaining it.

My current annotation approach is using https://github.com/shyim/junit-report-annotations-action which is no longer maintained, require extra coverage reporting and has some other inconveniences related to this. I would love to just a pytest plugin instead.

nicoddemus commented 1 year ago

Good question, I don't think I ever received the notification transfer, as I always act on it right away...

On Thu, Dec 8, 2022 at 9:50 AM Sorin Sbarnea @.***> wrote:

@utgwkk https://github.com/utgwkk @nicoddemus https://github.com/nicoddemus Any idea why this attempt got lost? I would find it very useful and will help maintaining it.

My current annotation approach is using https://github.com/shyim/junit-report-annotations-action which is no longer maintained, require extra coverage reporting and has some other inconveniences related to this. I would love to just a pytest plugin instead.

— Reply to this email directly, view it on GitHub https://github.com/pytest-dev/meta/issues/9#issuecomment-1342682443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAII57GRWRUFOU4MJVPPMTTWMHKRFANCNFSM5D4EUJ5Q . You are receiving this because you were mentioned.Message ID: @.***>

ssbarnea commented 1 year ago

If I remember well, at least in the past, repo owner would not be able to transfer a repository to another organization unless they already have permissions to create repos under that organizations. Me and you have but I do not know about @utgwkk

In same cases the workaround was to transfer to someone else which would transfer it again to the right destination.

Ideally it would have being a transfer request that needs approval, like joining a team, but is not like that. And obviously that allowing any github user to transfer their repos is not a good idea from.

@utgwkk If github does not allow you to transfer directly to pytest-dev, pick one of us, we will act as soon we read the notification, and restore permissions after transfer.

Luckly, no user is affected by transfer, ther implicit redirects works really nice.

nicoddemus commented 1 year ago

You are right Sorin, and what we do in pytest-dev is to ask the owner to transfer the repository to one of the core maintainers.

https://github.com/pytest-dev/pytest/blob/main/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev

In the case of pytest-github-actions-annotate-failures, I did offer myself and archived this thread, waiting for a notification that a repository transfer to me has been initiated, but that notification never came (neither the repository transfer request), so this slipped my mind.

[]s,

On Thu, Dec 8, 2022 at 11:55 AM Sorin Sbarnea @.***> wrote:

If I remember well, at least in the past, repo owner would not be able to transfer a repository to another organization unless they already have permissions to create repos under that organizations. Me and you have but I do not know about @utgwkk https://github.com/utgwkk

In same cases the workaround was to transfer to someone else which would transfer it again to the right destination.

Ideally it would have being a transfer request that needs approval, like joining a team, but is not like that. And obviously that allowing any github user to transfer their repos is not a good idea from.

@utgwkk https://github.com/utgwkk If github does not allow you to transfer directly to pytest-dev, pick one of us, we will act as soon we read the notification, and restore permissions after transfer.

— Reply to this email directly, view it on GitHub https://github.com/pytest-dev/meta/issues/9#issuecomment-1342857093, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAII57HOCV7VHAZBFR5FBHTWMHZFBANCNFSM5D4EUJ5Q . You are receiving this because you were mentioned.Message ID: @.***>

utgwkk commented 1 year ago

I'm sorry for waiting too much time, I've just transfer ownership of pytest-github-actions-annotate-failures to @ssbarnea (since I don't have permission to transfer to pytest-dev organization)

ssbarnea commented 1 year ago

Repo now reached https://github.com/pytest-dev/pytest-github-actions-annotate-failures but we need a pytest admin to restore repo owners on this package as I have no access at settings yet.

nicoddemus commented 1 year ago

I have created the appropriate teams and invited the members.

Let me know if anything is missing.

On Mon, Dec 19, 2022 at 10:18 AM Sorin Sbarnea @.***> wrote:

Repo now reached https://github.com/pytest-dev/pytest-github-actions-annotate-failures but we need a pytest admin to restore repo owners on this package as I have no access at settings yet.

— Reply to this email directly, view it on GitHub https://github.com/pytest-dev/meta/issues/9#issuecomment-1357656738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAII57ACKJ7OOTVXSY7U7EDWOBOAZANCNFSM5D4EUJ5Q . You are receiving this because you were mentioned.Message ID: @.***>

utgwkk commented 1 year ago

@nicoddemus I confirmed that I joined pytest-dev/pytest-github-actions-annotate-failures-admin team. Thank you! And could you invite @henryiii as a member of pytest-github-actions-annotate-failures repository? He contributed the repository so much before transferring it.

nicoddemus commented 1 year ago

Already did! :)

On Mon, Dec 19, 2022 at 11:35 AM utagawa kiki @.***> wrote:

@nicoddemus https://github.com/nicoddemus I confirmed that I joined pytest-dev/pytest-github-actions-annotate-failures-admin team. Thank you! And could you invite @henryiii https://github.com/henryiii as a member of pytest-github-actions-annotate-failures repository? He contributed the repository so much before transferring it.

— Reply to this email directly, view it on GitHub https://github.com/pytest-dev/meta/issues/9#issuecomment-1357763444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAII57G2JJ22VEEFFNZEXRTWOBXDXANCNFSM5D4EUJ5Q . You are receiving this because you were mentioned.Message ID: @.***>

utgwkk commented 1 year ago

I see, thank you so much!