search

pytest-dev / nose2pytest

Scripts to convert Python Nose tests to PyTest
Other
38 stars 12 forks source link

Use fissix in order to support newer python versions #17

Closed dosas closed 6 months ago

dosas commented 3 years ago

https://github.com/pytest-dev/nose2pytest/issues/16

jayvdb commented 3 years ago

Looks like there are two expected strings which need to be adjusted to match what fissix produces.

dosas commented 3 years ago

Looks like this is the same problem as described here https://github.com/pytest-dev/nose2pytest/issues/15

cclauss commented 2 years ago

@dosas Would you be willing to add the changes from #21 and then I can close #21? I think it would be easier for maintainers to review and accept the changes in this PR if it included working continuous integration testing.

dosas commented 2 years ago

@cclauss Done.

cclauss commented 2 years ago

Cool. Thanks. Let’s see what happens when a maintainer gives the jobs permission to run.

dosas commented 2 years ago

It will probably fail due to https://github.com/pytest-dev/nose2pytest/issues/15 ;)

cclauss commented 1 year ago

Please rebase.

jayvdb commented 1 year ago

ping @dosas

dosas commented 1 year ago

pong

schollii commented 1 year ago

Looks like this is still WIP? Also there are conflicts to resolve. Let me know when this is ready for review, I look forward to merging this.

cclauss commented 6 months ago

@schollii Your review, please.

schollii commented 6 months ago

I'm not seeing the tox test suite results proving that everything works fine after the changes, are they somewhere else? Sorry it's been a while since I looked at pytest cicd here.

Update : I can see "Checks waiting for approval" and a button "Approve and run", that's probably what will run tox but can someone confirm that's what I have to do, I don't want to approve PR until I see this.

nicoddemus commented 6 months ago

It needed approval to run the test suite (GH does that for first contributors to avoid crypto-spam).

Just gave approval, CI is running.

cclauss commented 6 months ago

Next steps?

nicoddemus commented 6 months ago

I guess all that is left is for @schollii to merge it?