pytest-dev / nose2pytest

Scripts to convert Python Nose tests to PyTest
Other
38 stars 12 forks source link

Replace Travis CI with GitHub Actions #18

Closed hugovk closed 3 years ago

hugovk commented 3 years ago

Travis CI is being turned off for the pytest-dev org (internal discussion), due to the recent security handling (1, 2).

This PR replaces Travis CI with GitHub Actions. It mostly replicates the old Travis workflow, the main differences is it runs using tox and adds caching.

And just like the last Travis build, it also fails for Python 3.8. I didn't look into it but it's a known issue so we have parity.

I also noticed that Python 3.7.1 (the last Travis CI build) and 3.7.7 (what I have on my machine) passed, but the latest 3.7 version on GHA (3.7.12) failed. So I've pinned to 3.7.7 in the CI. https://github.com/pytest-dev/nose2pytest/issues/15#issuecomment-726788746 also noted 3.7 failed, so this will need checking in the future (as part of #15).

Also, drop support for Python 3.4, it's not available on GHA, and anyway is EOL. We should also drop EOL 3.5 too. Shall I also remove it here?

Also, update Trove classifiers.

Finally, drop the dot in py.test :) https://twitter.com/pytestdotorg/status/753767547866972160

hugovk commented 3 years ago

Here's an example build:

https://github.com/hugovk/nose2pytest/actions/runs/1254263380

Please could someone enable GHA for this repo at https://github.com/pytest-dev/nose2pytest/actions?

nicoddemus commented 3 years ago

Please could someone enable GHA for this repo at pytest-dev/nose2pytest/actions?

Hmm how? Just create a dummy Python workflow?

Because I'm happy to just merge this and fix anything not working as it should afterward.

hugovk commented 3 years ago

If there's no big "Enable Actions button" at https://github.com/pytest-dev/nose2pytest/actions, then let's just merge and fix from there! Thanks!

nicoddemus commented 3 years ago

Yeah I don't see anything like that. 😁

Merging, thanks a lot for tackling this. πŸ‘

nicoddemus commented 3 years ago

Running: https://github.com/pytest-dev/nose2pytest/actions/runs/1254290050 πŸ‘