search

pytest-dev / nose2pytest

Scripts to convert Python Nose tests to PyTest
Other
38 stars 12 forks source link

Remove deprecated pytest_namespace #9

Closed PhilippSelenium closed 4 years ago

PhilippSelenium commented 4 years ago

Fix https://github.com/pytest-dev/nose2pytest/issues/8

PhilippSelenium commented 4 years ago

@nicoddemus I'm new to this. Does this need another approval or do I have to close the MR?

nicoddemus commented 4 years ago

@schollii is the main maintainer, we should ask for his input first. 😁

schollii commented 4 years ago

Thanks let me have a look

PhilippSelenium commented 4 years ago

@schollii The tests do fail on master branch with the latest pytest version:

pluggy.manager.PluginValidationError: unknown hook 'pytest_namespace' in plugin

The problem is that the tests have not been run since 2016. Is there a possibility to enable nightly or at least weekly builds? Or do you as a maintainer have the possibility to trigger a testrun on master?

PhilippSelenium commented 4 years ago

ping

schollii commented 4 years ago

@Nicodemus I've been out of the loop on such details what do you recommend to resolve this, does setting this up require anything from me?

nicoddemus commented 4 years ago

Hi @schollii,

Can you access https://travis-ci.org/github/pytest-dev/nose2pytest/settings?

nicoddemus commented 4 years ago

(Regardless, I think this is good to merge and release 👍)