search

pytest-dev / pluggy

A minimalist production ready plugin system
https://pluggy.readthedocs.io/en/latest/
MIT License
1.24k stars 121 forks source link

Rename misleading function name `PluggyManager.load_setuptools_entrypoints` #440

Closed noklam closed 1 year ago

noklam commented 1 year ago

https://github.com/pytest-dev/pluggy/blob/136bbe8c98b66cbcefdc2438bf3c59705678249b/src/pluggy/_manager.py#L376-L402

From my understanding this works beyond setuptools. PyPa suggested that this works for other build tools. From the implementation I can also see that it's not using anything specific to setuptools, it is using importlib.

Would it make sense to change it to load_entrypoints? I am happy to submit a PR if this is desirable. However this will be a breaking change.

noklam commented 1 year ago

I found this but discussion is outdated. https://github.com/pytest-dev/pluggy/issues/154

RonnyPfannschmidt commented 1 year ago

There's compatibility shim's and a few pain Points to resolve +downstream usages

So far nobody wanted to incurr that costs on downstreams

RonnyPfannschmidt commented 1 year ago

Closing as duplicate of #154