Implemented solution to issue #441 and added test cases

pytest-dev / pluggy

A minimalist production ready plugin system

https://pluggy.readthedocs.io/en/latest/

MIT License

1.24k stars 121 forks source link

Implemented solution to issue #441 and added test cases #461

Closed vishutupili closed 7 months ago

vishutupili commented 9 months ago

This PR is addressing issue #441

We have implemented the suggested change to the while loop condition.

Additionally, we have added test cases to test the order of hooks called to make sure that changing the while loop condition did not change the correct behaviour that the previous code was producing (specifically when hookwrapper and wrapper are set to False).

bluetech commented 8 months ago

Hi @vishutupili, the tests you added are passing also in current main. Can you add some tests the fail before the change and pass after?