pytest-dev / pluggy

A minimalist production ready plugin system
https://pluggy.readthedocs.io/en/latest/
MIT License
1.23k stars 121 forks source link

Possible to tell which hook answered a call? #485

Open simonw opened 5 months ago

simonw commented 5 months ago

I have some code that looks like this:

        opinions = []
        # Every plugin is consulted for their opinion
        for check in pm.hook.permission_allowed(
            datasette=self,
            actor=actor,
            action=action,
            resource=resource,
        ):
            check = await await_me_maybe(check)
            if check is not None:
                opinions.append(check)

        result = None
        # If any plugin said False it's false - the veto rule
        if any(not r for r in opinions):
            result = False
        elif any(r for r in opinions):
            # Otherwise, if any plugin said True it's true
            result = True

This is for a plugin-based permission model.

For easier debugging of complex situations (where more than one plugin might have contributed an opinion) I'd like to be able to tell which plugin returned which values.

Is there a way I can do this with Pluggy? If not, could I request it as a feature?

RonnyPfannschmidt commented 5 months ago

The details are not passed back, however hook tracing should be able to help debug