pytest-dev / py

Python development support library (note: maintenance only)
MIT License
69 stars 105 forks source link

Release 1.4.33 2nd attempt #114

Closed nicoddemus closed 7 years ago

nicoddemus commented 7 years ago

Supersedes #102

nicoddemus commented 7 years ago

Builds:

nicoddemus commented 7 years ago

@RonnyPfannschmidt I'm not entirely happy with the svn-related errors on Travis. I plan to investigate it a little bit later, but meanwhile do you have any idea of what the problem might be given that master passes and only devpi test is breaking?

Also, do we have any plans related to the svn functionality? I'm not sure how much it is used and how problematic it is to maintain it.

RonnyPfannschmidt commented 7 years ago

i have no plans, it has no maintainer and i recall its broken since a while now, i believe Travis skips them due to no svn

nicoddemus commented 7 years ago

RÁ oh my. It was failing because I generated the package on Windows, which left the testrepo.dump file with CRLF line endings. Surprisingly, svnadmin chokes on the file because of that (which doesn't inspire much confidence since the file is supposed to be TEXT). Fixed by adding a .gitattributes which forces that file type to always be checked out as LF line endings, and that seems to fix the tests, at least on Travis.

Other fixes:

With that the devpi test command on Travis is now green, although I doubt it will pass on Windows.

nicoddemus commented 7 years ago

@RonnyPfannschmidt once you are OK with the changes, I can publish the package and will try to spend a couple of hours cleaning up the test suite so it works on Pytest 3.0.

RonnyPfannschmidt commented 7 years ago

@nicoddemus if it works im happy ^^