search

pytest-dev / py

Python development support library (note: maintenance only)
MIT License
67 stars 106 forks source link

Drop support for EOL Python <= 2.6, 3.0-3.3 #165

Closed hugovk closed 6 years ago

hugovk commented 6 years ago

Fixes #159.

hugovk commented 6 years ago

The Travis CI "runslowtests" job is failing in the same way as master.

I've not compared Appveyor, but I see that's also failing on master.

hugovk commented 6 years ago

Any thoughts on merging this?

I see https://github.com/pytest-dev/py/pull/158 added "this library is in maintenance mode and should not be used in new code", and dropping support for EOL Pythons would make that maintenance easier.

nicoddemus commented 6 years ago

Hi @hugovk sorry for the silence here, thanks for tackling this!

We definitely want to merge this; the next pytest release (3.3) already dropped support for Python 2.6 and 3.3.

Would you mind rebasing/merging with the latest master? #157 fixed all tests in Linux and Windows so we can then merge this with more confidence. Also, I added an xfail in #157 for 2.6 which we could remove in this PR as well.

hugovk commented 6 years ago

@nicoddemus Rebased, and reverted bdc9112b0982f0d5d195b8e088cd71b3ab578a14!

nicoddemus commented 6 years ago

Are we to release 1.5.0 or 2.0 given the fact we are dropping 2.6 and 3.3?

We should decide and release pytest-3.2.4 with the appropriate pin, so the next pytest release will allow users to pin appropriately to the pytest version if the need to continue using 2.6 or 3.3. I see two options:

  1. py-1.5 and pytest-3.3: then pytest-3.2.4 (the next bugfix) should pin to py<1.5.
  2. py-2.0 and pytest-4.0: then pytest-3.2.4 (the next bugfix) should pin to py<2.0.

@RonnyPfannschmidt @The-Compiler @flub @hackebrot @hpk42 what do you guys think?

RonnyPfannschmidt commented 6 years ago

@nicoddemus i beleive a 1.5.0 is fine - but we should make a removal note about it (since those are EOL python version i think its fine to expect due diligence from those not fixing that problem)

nicoddemus commented 6 years ago

but we should make a removal note about it

Done

nicoddemus commented 6 years ago

If nobody manifests against it until then, I will open a PR on pytest tomorrow pinning py<1.5, then we can release pytest-3.2.4 with the pin and then finally we can release py-1.5.

nicoddemus commented 6 years ago

Actually I went ahead and created the PR now: pytest-dev/pytest#2916. We can wait until tomorrow to merge it; if nobody objects, I will merge and get pytest-3.2.4 rolling.

nicoddemus commented 6 years ago

Thanks @hugovk again!

Now we just need to wait for pytest-3.2.4 to go out before releasing py-1.5. 👍