Drop support for EOL Python 3.4

[hugovk]

~Also rename appveyor.yml to .appveyor.yml to hide it with the other dotfiles, and update some links.~ --> split out to #233.

[codecov-io]

Codecov Report

Merging #226 into master will decrease coverage by 0.1%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   82.06%   81.96%   -0.11%     
==========================================
  Files          55       55              
  Lines       10161    10161              
  Branches     1141     1141              
==========================================
- Hits         8339     8328      -11     
- Misses       1558     1569      +11     
  Partials      264      264

[jayvdb]

Note that there is an unreleased fix for py34, which really should be released before dropping support for py34.

[hugovk]

Sounds reasonable. Is there a schedule for the next release?

[hugovk]

I see py 1.8.1 has now been released with the Python 3.4 fix:

https://github.com/pytest-dev/py/blob/1058b29ce8aac2f9ca0944d3cf1aff8fc0ddb58c/CHANGELOG#L1-L5

Ready for merge?

[blueyed]

@hugovk there are some good changes in here (e.g. https://github.com/pytest-dev/py/pull/226/commits/f07e10591caf963330dd37abd8cef50ed108b36d), but IMHO there is no need to drop support if it is not really necessary. AFAICS py is in maintenance mode, so there is nothing like e.g. type annotations being added to the code etc, which would benefit from it. (btw: typing stubs are being worked on in https://github.com/pytest-dev/py/pull/232). So I suggest to get your non-dropping changes merged via new PR maybe by themselves already. Just my 2 cents however.

[hugovk]

@blueyed Yes, the main benefit is dropping a few slots from the CI. But if the code isn't updated much, that's no as important.

However, 3.4 is now failing on AppVeyor so it looks like some dependencies need pinning to maintain support.

So I suggest to get your non-dropping changes merged via new PR maybe by themselves already.

Good idea, please see PR https://github.com/pytest-dev/py/pull/233.

[blueyed]

@hugovk

Yes, the main benefit is dropping a few slots from the CI.

That could still be done, of course (or reduced). But removing it from install_requires for example is not really necessary (currently).

[blueyed]

For reference: py34 on AppVeyor fails via pytest installing colorama:

Collecting colorama; sys_platform == "win32" (from pytest~=2.9.0)
  Downloading https://files.pythonhosted.org/packages/31/cb/88c908c1be067fb6bacd3d7488ccab1a212533767b951933aac3d22648e2/colorama-0.4.2-py2.py3-none-any.whl
colorama requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*' but the running Python is 3.4.4
You are using pip version 10.0.1, however version 19.1.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.

[blueyed]

I've created https://github.com/pytest-dev/py/pull/235 to remove py34 from AV.

[hugovk]

Rebased to the remove the non-drop changes in https://github.com/pytest-dev/py/pull/233.

[blueyed]

Please squash.

I'd like to be able doing it here, but cannot...

[hugovk]

Done!