Regression introduced in py.path.local.dirpath in 8e65cb5

pytest-dev / py

Python development support library (note: maintenance only)

MIT License

69 stars 105 forks source link

Regression introduced in py.path.local.dirpath in 8e65cb5 #62

Closed pytestbot closed 8 years ago

pytestbot commented 8 years ago

Bitbucket: https://bitbucket.org/pytest-dev/py/issue/62
Originally reported by: @aldanor
Originally created at: 2015-05-21T10:43:39.247

Due to the recent changes in 140e8d5, py.path.local.dirpath no longer passes keyword arguments to py.path.local.join, hence code like this becomes broken:

path.dirpath(*args, abs=True)

Suggestion: only use the optimization if no keyword arguments are provided, otherwise fall back to the original behaviour.

pytestbot commented 8 years ago

Original comment by @aldanor

Closed by PR 29

pytestbot commented 8 years ago

Original comment by @aldanor

Indeed.

@hpk42, thanks for fixing a typo in the test by the way!

pytestbot commented 8 years ago

Original comment by @blueyed

The PR (https://bitbucket.org/pytest-dev/py/pull-request/29) has been merged. This issue can be closed.

pytestbot commented 8 years ago

Original comment by @aldanor

@hpk42 opened PR#29

pytestbot commented 8 years ago

Original comment by @hpk42

yes, makes sense, can you prepare a PR?