Open kloczek opened 1 month ago
I'v been trying to update pyfakefs for python>=3.8
Why would you do that? pyfakefs
still supports 3.7 (yes, I know that it's EOL), so I may run this after 3.7 support is removed.
I will check of course what causes this and probably fix it, but I don't consider this a bug.
3.7 has been EOSed almost year ago https://endoflife.date/python In Oct this year 3.8 will be EOEsed.
3.7 has been EOSed almost year ago
Yes, I know, and I already wanted to remove the support once - wasn't a good idea. The currrent policy is to support a version as long as it is available in the CI (which won't be long now).
There is no any issues with supporting even older versions on branches if any critical bug will be found .. ALL VCS platforms are to deal with that in civilised form.
Other thing is that it would be really good to make the code redy to be automatically upgradeable using pyupgrade
.
I checked, and the problem doesn't have to do with 3.7 compatibility, but with one specific change (replacing io.open
by open
) which breaks pyfakefs. io.open
is intentionally used here, because open
may be faked at that moment, and we need the real fs. Maybe this can be implemented differently, but this does not have a hight priority. pyupgrade
found a few other overlooked left-overs from earlier versions that can indeed be changed, so this is helpful anyway.
I understand. Thank you for your time 👍
I'v been trying to update
pyfakefs
for python>=3.8 and I found that modifications generated by this tool are causing that pytest fails in 6 units.it would be good to make
pyfakefs
code ready forpyupgrade
and/or adjust whatever is needed inpyupgrade
.