Use an env var as the default base_url if one exists

pytest-dev / pytest-base-url

pytest plugin for URL based tests

Other

38 stars 11 forks source link

Closed m8ttyB closed 7 years ago

m8ttyB commented 7 years ago

A pr for issue #1. If an environment variable for PYTEST_BASE_URL is set, pytest-base-url will use it as the default url.

Note, I'm not sure if defaulting to None is required. I chose a default of None for semantics and readability. The test suite passes for both variations; default=os.getenv('PYTEST_BASE_URL', None) and default=os.getenv('PYTEST_BASE_URL')

nicoddemus commented 7 years ago

IMHO looks good, I just think it is missing some docs. One section to the README after "Using a Configuration File" would suffice.

davehunt commented 7 years ago

Thanks @m8ttyB - I'll release a new version next week.