pytest-dev / pytest-bdd

BDD library for the pytest runner
https://pytest-bdd.readthedocs.io/en/latest/
MIT License
1.32k stars 221 forks source link

Adapt to `getfixturedefs` change in pytest 8.1 #666

Closed bluetech closed 10 months ago

bluetech commented 10 months ago

The signature of this (private) function will change in the upcoming pytest 8.1 release: https://github.com/pytest-dev/pytest/pull/11785

Additionally, the iterparentnodeids function is removed, so copy/pasting it for now.

I verified that all tests pass when run against pytest main.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8a694ff) 95.58% compared to head (32a19ce) 95.18%.

Files Patch % Lines
src/pytest_bdd/scenario.py 80.00% 3 Missing and 3 partials :warning:
src/pytest_bdd/compat.py 76.92% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #666 +/- ## ========================================== - Coverage 95.58% 95.18% -0.41% ========================================== Files 49 50 +1 Lines 1788 1826 +38 Branches 193 200 +7 ========================================== + Hits 1709 1738 +29 - Misses 52 57 +5 - Partials 27 31 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

youtux commented 10 months ago

Fixes #668

youtux commented 10 months ago

I got the pytest version check wrong, fixing it in https://github.com/pytest-dev/pytest-bdd/pull/669

IvanBuruyane commented 9 months ago

@youtux , thanks for the fix. Do you know when the fix will be released?

youtux commented 9 months ago

I'll do a release later today

youtux commented 9 months ago

pytest-bdd 7.1.1 is out