search

pytest-dev / pytest-bdd

BDD library for the pytest runner
https://pytest-bdd.readthedocs.io/en/latest/
MIT License
1.32k stars 221 forks source link

Only use the official Gherkin parser objects and remove custom parser logic #699

Closed jsa34 closed 2 months ago

jsa34 commented 2 months ago

Going a step further than my previous PR that simply parsed the feature files using the official parser, but then copied this data into the existing parser objects, this PR removes the old parser completely and either uses the data directly that is parsed into the models from the Gherkin parser or adds needed functionality to the Gherkin parser models to enhance just being DAOs for pytest-bdd to use the data as it needs to.

jsa34 commented 2 months ago

I'm thinking a different approach might be better to keep the DAO/mapping and logic encapsulated

sourcery-ai[bot] commented 2 months ago

🧙 Sourcery has finished reviewing your pull request!

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
jsa34 commented 2 months ago

Closed to focus on parser, and ended up just dumping things I was trying on this branch - apologies!