pytest-dev / pytest-bdd

BDD library for the pytest runner
https://pytest-bdd.readthedocs.io/en/latest/
MIT License
1.32k stars 221 forks source link

Test for slashes in Scenario Outline's Examples table #709

Closed jsa34 closed 1 month ago

jsa34 commented 2 months ago

Add test that forward slashes (in URLs for example) in scenario outline examples are handled properly by the parser.

Resolves #655

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.30%. Comparing base (86f4ee1) to head (aecff18). Report is 9 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #709 +/- ## ========================================== + Coverage 95.28% 95.30% +0.01% ========================================== Files 53 53 Lines 2016 2023 +7 Branches 228 228 ========================================== + Hits 1921 1928 +7 Misses 58 58 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsa34 commented 2 months ago

@youtux Not sure why this fails with py3.10, but my local 3.8 and the GH action for 3.12 was fine...

youtux commented 2 months ago

@youtux Not sure why this fails with py3.10, but my local 3.8 and the GH action for 3.12 was fine...

It's failing the py3.10-pytest6.2-coverage build, so when used in combination with pytest 6.2. We should just drop that old version of pytest

youtux commented 2 months ago

Dropping compatibility with pytest 6.2 in https://github.com/pytest-dev/pytest-bdd/pull/711

jsa34 commented 2 months ago

Ah, thought I'd done that, but I had in a branch where this was also an issue but it hadn't been merged yet. My fault for raising too many MRs in a short space of time!

jsa34 commented 1 month ago

Looks like a recurring issue with xdist/test suite hanging until timeout clears it up. Could be to do with coverage in the post-suite phase(?) Not sure how to fix this (unrelated to MR and happened in other branches)...

jsa34 commented 1 month ago

Looks like CI flakiness gods were in my favour this time. Happy to merge, @youtux ?

youtux commented 1 month ago

Yes!