pytest-dev / pytest-bdd

BDD library for the pytest runner
https://pytest-bdd.readthedocs.io/en/latest/
MIT License
1.32k stars 221 forks source link

Add rule logic #726

Closed jsa34 closed 1 month ago

jsa34 commented 1 month ago

Make keywords for gherkin not hardcoded Add logic for handling rules Permeate keywords and synonyms that rule-based format tends to use to outputs used in Pytest-BDD

youtux commented 1 month ago

Hey would you mind splitting this into multiple PRs? It would make it easier to review. They can be sta led on top of each other

jsa34 commented 1 month ago

Okie dokie :)

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.98361% with 11 lines in your changes missing coverage. Please review.

Project coverage is 95.56%. Comparing base (00916ff) to head (071bb12). Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/pytest_bdd/gherkin_terminal_reporter.py 87.23% 4 Missing and 2 partials :warning:
src/pytest_bdd/generation.py 42.85% 3 Missing and 1 partial :warning:
src/pytest_bdd/parser.py 97.56% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #726 +/- ## ========================================== - Coverage 95.60% 95.56% -0.04% ========================================== Files 54 55 +1 Lines 2071 2143 +72 Branches 231 249 +18 ========================================== + Hits 1980 2048 +68 - Misses 55 58 +3 - Partials 36 37 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsa34 commented 1 month ago

I'll do one at a time - just raised #727

youtux commented 1 month ago

Can you rebase your changes on the master branch?

jsa34 commented 1 month ago

Ugh - it's got messy... I'll open a new PR