search

pytest-dev / pytest-bdd

BDD library for the pytest runner
https://pytest-bdd.readthedocs.io/en/latest/
MIT License
1.32k stars 221 forks source link

Add rule feature #728

Closed jsa34 closed 1 week ago

jsa34 commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.73684% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.70%. Comparing base (f47c6d2) to head (d67a7b8).

Files with missing lines Patch % Lines
src/pytest_bdd/gherkin_terminal_reporter.py 72.22% 4 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #728 +/- ## ========================================== - Coverage 95.74% 95.70% -0.05% ========================================== Files 54 55 +1 Lines 2114 2187 +73 Branches 228 192 -36 ========================================== + Hits 2024 2093 +69 - Misses 55 58 +3 - Partials 35 36 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsa34 commented 1 month ago

@youtux Created a new PR with the rule feature in as I messed up the rebasing!

jsa34 commented 3 weeks ago

Implemented all feedback.

Just this: https://github.com/pytest-dev/pytest-bdd/pull/728#discussion_r1815345859 I think needs to be as it is, so we know what type of background it is (under a feature or under rule), but may have misunderstood the suggestion!

Poogles commented 2 weeks ago

Hero thanks for implementing this and the data tables work. <3

jsa34 commented 2 weeks ago

Pleasure!

Glad it is hopefully helpful!

jsa34 commented 2 weeks ago

@youtux is there anything else after this that would be necessary for a V8 release? (I'm assuming https://github.com/pytest-dev/pytest-bdd/milestone/1 is our definition of what we want to achieve for v8? If so, I can pick up the multiple examples table one and then i think that's it in terms of features)

youtux commented 2 weeks ago

Not necessarily. If https://github.com/pytest-dev/pytest-bdd/pull/489 is not a backwards incompatible change, it can go in a minor release.

I think if we merge this we can release v8.0.0.

youtux commented 2 weeks ago

Unless there are outstanding issues I forgot about

youtux commented 2 weeks ago

I'll try reviewing this in the weekend if I manage

jsa34 commented 2 weeks ago

No rush at all - Appreciated as always!

jsa34 commented 2 weeks ago

Committed responses to latest feedback :)

jsa34 commented 2 weeks ago

Removed feature field from Rule

jsa34 commented 1 week ago

Feedback resolved :)

jsa34 commented 1 week ago

Addressed feedback :)

jsa34 commented 1 week ago

@youtux tried rerunning the checks, but codecov consistently seems unhappy. Not sure what's happening...

youtux commented 1 week ago

Yeah there's something going on with codecov. I'll merge this manually