search

pytest-dev / pytest-bdd

BDD library for the pytest runner
https://pytest-bdd.readthedocs.io/en/latest/
MIT License
1.32k stars 221 forks source link

Render docstrings and datatable cells with example table entries #743

Closed jsa34 closed 2 days ago

jsa34 commented 5 days ago

Render scenario names, docstrings and datatable cells with example table entries, just like step names currently are.

Fixed another issue that I hadn't seen before that background steps were also not able to be rendered using the current logic. This is now fixed.

Resolves #741 Resolves #252

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.01%. Comparing base (1e5595b) to head (3f42ef3). Report is 15 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #743 +/- ## ========================================== + Coverage 95.95% 96.01% +0.06% ========================================== Files 55 55 Lines 2200 2211 +11 Branches 242 244 +2 ========================================== + Hits 2111 2123 +12 + Misses 54 53 -1 Partials 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

youtux commented 2 days ago

hey I took the liberty of applying some changes directly, hope you don't mind. If that's fine to you, I'd merge it.

jsa34 commented 2 days ago

hey I took the liberty of applying some changes directly, hope you don't mind. If that's fine to you, I'd merge it.

Not at all! I did notice when I code reviewed that the STEP_PARAM_RE regex is no longer just for steps so renamed it.

jsa34 commented 2 days ago

I can't merge :(. Sorry my new commit invalidated your approval @youtux

youtux commented 2 days ago

turns out that the Step.params method is unused, so I removed it.