search

pytest-dev / pytest-cov

Coverage plugin for pytest.
MIT License
1.72k stars 211 forks source link

Testing requirements are outdated #602

Open aqeelat opened 1 year ago

aqeelat commented 1 year ago

I'm going through the poetry.lock file in one of my projects and searching for packages that still use six in order to help the package maintainers drop support for python 2.7.

However, pytest-cov lists six as a testing requirement even though it does not support python 2.7. I also came across a couple of issues that I would like to let you know about.

setup.py says that:

  1. six is required but it is not actually used in the project
  2. process-tests is in setup.py but not in ci/requirements.txt
  3. hunter was added in https://github.com/pytest-dev/pytest-cov/commit/0d75fd2c5f9f39f0f7eadb626a75a728a2c6dc2a with no code dependency. I think this might be a local debugging tool that @ionelmc was using.

https://github.com/pytest-dev/pytest-cov/blob/2c9f2170d8575b21bafb6402eb30ca7de31e20b9/setup.py#L136-L145 These dependencies were moved from tox which made them hard to track.

RonnyPfannschmidt commented 1 year ago

Thanks for digging those oversights up,now they can be resolved

The quickest way may be a PR with the fix

aqeelat commented 1 year ago

@RonnyPfannschmidt if process-tests is required but not in https://github.com/pytest-dev/pytest-cov/blob/master/ci/requirements.txt, then how were the tests being run?

The're used here: https://github.com/pytest-dev/pytest-cov/blob/master/tests/test_pytest_cov.py#L16

a-detiste commented 10 months ago

I made a PR for six. I do like too provide a bit of help to random projects:

https://wiki.debian.org/Python3-six-removal