search

pytest-dev / pytest-cov

Coverage plugin for pytest.
MIT License
1.72k stars 211 forks source link

remove rsyncdir usage since pytest-xdist has deprecated it #623

Closed matthias-margin closed 5 months ago

matthias-margin commented 8 months ago

This removes the usage of rsyncdir so that pytest-xdist does not raise a deprecation warning. Trying to get all warning in my projects to go away.

Issue submitted a bit ago https://github.com/pytest-dev/pytest-cov/issues/621 and a older one too https://github.com/pytest-dev/pytest-cov/issues/557

lesteve commented 7 months ago

@ionelmc it seems like this should be merged. You said yourself in https://github.com/pytest-dev/pytest-cov/issues/557#issuecomment-1579332066

Well I guess there could be another pytest-cov release outright removing the rsync stuff. Would that make everyone happy?

And the response to your question seems to be a clear yes:

mscheltienne commented 5 months ago

@ionelmc pinging as well, a merge of this PR and a new release would be appreciated.

ionelmc commented 5 months ago

It's in master now (rebased).

rschwebel commented 5 months ago

Thanks for taking care about this! This patch is now in 5.0.0, but it hasn't been rolled out to pypi. Could someone take care of that?

ionelmc commented 5 months ago

Yeah, this weekend I'll have time for it.