search

pytest-dev / pytest-forked

extracted --boxed from pytest-xdist to ensure backward compat
MIT License
62 stars 21 forks source link

`pytest_runtest_logstart` and `pytest_runtest_logfinish` are not in effect #31

Closed wy-z closed 4 years ago

wy-z commented 4 years ago

pytest-forked reimplemented pytest_runtest_protocol, but pytest_runtest_logstart and pytest_runtest_logfinish were ignored.

Here are the codes in pytest-forked and pytest: https://github.com/pytest-dev/pytest-forked/blob/bedbc83b139deede2aa90257e234749561600cc9/src/pytest_forked/__init__.py#L40-L45 https://github.com/pytest-dev/pytest/blob/259e5d0610202453f9beace6cab336b11d4353a9/src/_pytest/runner.py#L87 image

wy-z commented 4 years ago

How about implementing pytest_runtest_logstart and pytest_runtest_logfinish in pytest_runtestloop instead of in pytest_runtest_protocol? @nicoddemus https://github.com/pytest-dev/pytest/blob/4f8fff9cab6e2333890e21eb840724e7e4d41763/src/_pytest/main.py#L260-L277 image

webknjaz commented 4 years ago

@wy-z this library is in maintenance mode. It is unlikely that the maintainers will implement your request but if you want to send a PR — feel free. Just make sure that it's well-covered by tests.