Fix test_xfail_behavior with pytest 7.2.0+

pytest-dev / pytest-forked

extracted --boxed from pytest-xdist to ensure backward compat

MIT License

62 stars 21 forks source link

Closed swt2c closed 1 year ago

swt2c commented 1 year ago

In https://github.com/pytest-dev/pytest/commit/69fb79e741f00714d3ac14ee853c5506f154e94f, pytest output was changed to include the reason string on the same line as the short test summary, so the test needs to be updated correspondingly.

frenzymadness commented 1 year ago

Looks good to me! A few notes:

GH action no longer supports Python 3.6, if you want to test with it, take a look at https://github.com/fedora-python/tox-github-action
The latest pytest does not support Python 3.6 so the tox.ini also needs an update.
It would be nice to have a new release with this fix because the latest one is almost a year old.

I did a manual test locally and it seems that it works well. Thank you!

swt2c commented 1 year ago

On your first two bullets - yep, see #75

nicoddemus commented 1 year ago

I suggest we just cherry-pick 8d722cb0b1cc12d7207a88e93043b28e71ed7a17 on top of #75 and merge that PR. :+1:

swt2c commented 1 year ago

Done.

webknjaz commented 1 year ago

GH action no longer supports Python 3.6, if you want to test with it, take a look at fedora-python/tox-github-action

FYI it is possible to get 3.6 in GHA if you set runs-on to an older Ubuntu.