Open ssbarnea opened 5 years ago
@ssbarnea Really good ideas! I don't have any objections. We should however be careful to not introduce any breaking changes. Specifically regarding the hooks. (Not that I think that any of the proposed changes would cause that.)
I also like to be able to put screenshots vertically and not just horizontally, if you have many screenshots in one test they take from the screen capture output.
The environment stuff is also a big security issue. We use gitlab ci to deploy containers and pytest-html pics up all the CI* and GITLAB* environment variables, they are useless for the the test but holds the project token and password in public
@fenchu
I also like to be able to put screenshots vertically and not just horizontally, if you have many screenshots in one test they take from the screen capture output.
We have a solution in #112 and I'm happy to have someone take over that from me!
The environment stuff is also a big security issue. We use gitlab ci to deploy containers and pytest-html pics up all the CI* and GITLAB* environment variables, they are useless for the the test but holds the project token and password in public
You can remove useless/sensitive metadata per the instructions here.
Currently pytest-html report is wasting a huge amount of valuable screen space with boilerplace stuff, which most of the time are of no use to the user. In 99% of the cases the user that opens a report is doing it because a test failed, so he should not have to scroll down in order to find out which test failed.
I proposed few changes in the annotated screenshot I made in order to get some feedback from project maintainers regarding if they want these feature or not. Once I get the feedback I can work on making a PR to improve the output.