search

pytest-dev / pytest-qt

pytest plugin for Qt (PyQt5/PyQt6 and PySide2/PySide6) application testing
https://pytest-qt.readthedocs.io
MIT License
409 stars 70 forks source link

Clean up old qt_compat aliases #358

Closed The-Compiler closed 3 years ago

The-Compiler commented 3 years ago

Removes all aliases to class names, since those were only needed back when those classes were in different modules between Qt 4 and Qt 5 (typically QtGui vs. QtWidgets).

With Qt 4 now dropped, Qt 5 and Qt 6 are compatible enough to use the full path to the classes inside our code instead, which makes the wrapper much simpler.

This also cleans up some tests doing "QtCore = qt_api.QtCore" or similar, since there were a lot of duplicated but unused such aliases. Seems simpler to me to just use the direct name, even if a bit longer.

Fixes #354

The-Compiler commented 3 years ago

Wheee, thanks for all the quick reviews!

nicoddemus commented 3 years ago

Wheee, thanks for all the quick reviews!

Sure thing, thanks for tackling all this and spearheading the next release. 😁