search

pytest-dev / pytest-qt

pytest plugin for Qt (PyQt5/PyQt6 and PySide2/PySide6) application testing
https://pytest-qt.readthedocs.io
MIT License
409 stars 70 forks source link

Make wait* arguments kw-only #368

Closed The-Compiler closed 3 years ago

The-Compiler commented 3 years ago

Closes #366

The-Compiler commented 3 years ago

Thanks for all the reviews! :+1:

What's left to do the release? Remove the UNRELEASED in the changelog and push a tag?

nicoddemus commented 3 years ago

Pretty much! 😁

Also feel free to do the honours of announcing the new release on Twitter, given you did all the work on the new release. 🙇

The-Compiler commented 3 years ago

Done, release build is running: https://github.com/pytest-dev/pytest-qt/actions/runs/903331101 - fingers crossed that the PyPI deploy stuff still works after such a long time! :crossed_fingers:

Took the freedom to push to master directly (f258f31954ce5dd932d574ca8182d3703127c500) given that the only thing left was the date and the CI already passed recently.

edit: Looks like it worked, will follow up with an announcement once I'm home.

nicoddemus commented 3 years ago

Awesome!