pytest-dev / pytest-qt

pytest plugin for Qt (PyQt5/PyQt6 and PySide2/PySide6) application testing
https://pytest-qt.readthedocs.io
MIT License
409 stars 70 forks source link

Correct and clarify parameter names for qtbot.mouse* #472

Closed oscargus closed 1 year ago

oscargus commented 1 year ago

There was an inconsistency between stateKey and modifier in the docs (stateKey in the signature, modifier in the parameters). Also, pos in the signature and position in the parameters.

This makes is consistent and clarifies that stateKey is used in the pyside bindings (both 2 and 6). (modifier is used in the PyQT bindings, not sure which one should be considered the "default". Although PySide is loaded first, the benefit with modifier is that it is used in `key`, which is referred to.)

As a side note, it could be an option for pytest-qt to adapt the keyword argument name depending on the binding.

Edit: I also added the enum Namespace where missing.