search

pytest-dev / pytest-repeat

pytest plugin for repeating test execution
https://pypi.python.org/pypi/pytest-repeat/
Other
172 stars 27 forks source link

py312 #70

Closed okken closed 1 year ago

okken commented 1 year ago

@nicoddemus A few questions:

  1. Do you want me to tag you (or someone else, maybe @RonnyPfannschmidt) as the reviewer for all PRs, just PRs I'd like feedback on, or not at all? example: this PR seems pretty basic and not needing review.
  2. CI is set up for testing all versions on both windows and ubuntu. Is that overkill? Ubuntu enough? Or maybe just latest on windows (if possible)?
  3. Tox is testing against old versions of pytest, CI is not. Is the tox testing against old versions of pytest overkill? If not, I'll probably try to add it to CI also.

Also, thanks for your patience and assistance with this project and onboarding me.

Thanks

nicoddemus commented 1 year ago

Do you want me to tag you (or someone else, maybe @RonnyPfannschmidt) as the reviewer for all PRs, just PRs I'd like feedback on, or not at all?

I would prefer only if you would like specific feedback from me, thanks.

CI is set up for testing all versions on both windows and ubuntu. Is that overkill? Ubuntu enough? Or maybe just latest on windows (if possible)?

I particularly prefer to always test all version in all platforms, specially if the cost is just a couple of extra minutes, but feel free to change that if it will simplify your workflow.

Tox is testing against old versions of pytest, CI is not. Is the tox testing against old versions of pytest overkill? If not, I'll probably try to add it to CI also.

If a plugin declares support for some minimum pytest version (say 5.0+), I think it is important to test against that pytest version, at least with 1 compatible Python version (latest is fine). For the rest of the tests, running against latest pytest and all supported Python versions is good enough I think.

okken commented 1 year ago

Thanks @nicoddemus