search

pytest-dev / pytest-rerunfailures

a pytest plugin that re-runs failed tests up to -n times to eliminate flakey failures
Other
369 stars 82 forks source link

Fix crash with setup errors and --rerun-except flag #244

Closed Joonalai closed 7 months ago

Joonalai commented 7 months ago

This PR fixes internal errors on setup (non-existent fixtures etc) that occur when using --rerun-except flag.

I am wondering whether reruns should occur when failure happens on setup part of the test?

icemac commented 7 months ago

I am wondering whether reruns should occur when failure happens on setup part of the test?

If an error occurs that early probably rerunning does not help, but this could be solved in another PR.

Joonalai commented 7 months ago

I am wondering whether reruns should occur when failure happens on setup part of the test?

If an error occurs that early probably rerunning does not help, but this could be solved in another PR.

I agree, maybe another issue or PR should be opened for this.

icemac commented 7 months ago

Thank you for this PR. 😃