pytest-dev / pytest-rerunfailures

a pytest plugin that re-runs failed tests up to -n times to eliminate flakey failures
Other
380 stars 83 forks source link

refactor: migrate `setup.cfg` to `pyproject.toml` #251

Closed Borda closed 7 months ago

Borda commented 7 months ago

Following the Python best practice, it would be good to use pyproject.toml instead of setup.cfg and as pyproject.toml already exists in this project so it also simplifies the project complexity.

cc: @sallner @florianpilz @hugovk

hugovk commented 7 months ago

Good idea, let's drop support for 3.7 first: https://github.com/pytest-dev/pytest-rerunfailures/pull/254

Please can you also add these to pre-commit, after pyupgrade?

  - repo: https://github.com/tox-dev/pyproject-fmt
    rev: 1.7.0
    hooks:
      - id: pyproject-fmt
        additional_dependencies: [tox]

  - repo: https://github.com/abravalheri/validate-pyproject
    rev: v0.16
    hooks:
      - id: validate-pyproject
hugovk commented 7 months ago

Good idea, let's drop support for 3.7 first: #254

254 has been merged, please could you resolve conflicts?

Borda commented 7 months ago

please could you resolve conflicts?

Done, just debugging why the installation may not work... when I build package python -m build and browse sdist I see all needed files, but for tests, it is complaining