precommit: use Sphinx Lint check

[Borda]

Just a suggestion: shall we use this hook instead of local and consecutively fix duplicated reference targets?

cc: @hugovk

[hugovk]

I'm not sure why it was originally added as a local tool, but seems to make more sense as a repo.

Any idea why pygments and restructuredtext_lint were additional_dependencies? If we don't need them, let's remove the empty additional_dependencies.

About the duplicates, they look valid, because https://github.com/pytest-dev/pytest-rerunfailures/blob/master/CHANGES.rst is like:

13.0 (2023-11-22)

Breaking changes

Features

Bug fixes

12.0 (2023-07-05)

Breaking changes

Features

Bug fixes

[hugovk]

Any idea why pygments and restructuredtext_lint were additional_dependencies?

Ah, because restructuredtext_lint and rstcheck are different tools :)

How similar are they?

There's also https://github.com/sphinx-contrib/sphinx-lint (which I help maintain).

[Borda]

There's also https://github.com/sphinx-contrib/sphinx-lint (which I help maintain).

Sound like a good alternative =)

[icemac]

I think restructuredtext_lint just predates sphinx-lint.

[Borda]

@icemac @hugovk, mind reviewing this PR? :flamingo:

[hugovk]

These look like valid errors, please could you fix them?

CHANGES.rst:93: default role used (hint: for inline literals, use double backticks) (default-role)
CHANGES.rst:117: default role used (hint: for inline literals, use double backticks) (default-role)
CHANGES.rst:322: default role used (hint: for inline literals, use double backticks) (default-role)
CHANGES.rst:417: default role used (hint: for inline literals, use double backticks) (default-role)
README.rst:48: default role used (hint: for inline literals, use double backticks) (default-role)

[Borda]

These look like valid errors, please could you fix them?

@hugovk done :chipmunk: