pytest-dev / pytest-splinter

pytest splinter and selenium integration for anyone interested in browser interaction in tests
MIT License
253 stars 51 forks source link

Screenshots won't work with pytest 5 #136

Open pedrospdc opened 4 years ago

pedrospdc commented 4 years ago

In _browser_screenshot_session, you have the following code:


    fixture_values = (
        # pytest 3
        getattr(request, '_fixture_values', {}) or
        # pytest 2
        getattr(request, '_funcargs', {})
    )

    for name, value in fixture_values.items():

None of these getters are set in pytest 5.

mpasternak commented 2 years ago

Is the problem still applicable? We're on pytest 7 and the code seems to be working just fine. Please let me know if this is still a problem, or even better, submit a PR with fix. Thanks.