pytest-dev / pytest-testinfra

Testinfra test your infrastructures
https://testinfra.readthedocs.io
Apache License 2.0
2.37k stars 355 forks source link

Add Windows support for File and Service modules #683

Closed tdas3001 closed 1 year ago

tdas3001 commented 1 year ago

Opened a new PR for adding Windows support for File and Service modules in Testinfra as the old one #532 has been inactive for quite some time. The PR contains all the changes in #532 and a few more implementations.

# Basic file and service operations are now supported in windows remote server
>>> host.file("C:/Users/Administrator/pytest-testinfra").is_directory
True
>>> host.file("C:/Users/Administrator/pytest-testinfra/images").listdir()
['alphine', 'archlinux', 'debian_bullseye', 'rockylinux8', 'ubuntu_xenial']

Please let me know of any comments.

tdas3001 commented 1 year ago

@philpep feel free to have a look at the PR

tdas3001 commented 1 year ago

Thanks! Like I said in some other PR, I don't have knowledge neither time to maintain this. However this PR looks almost reasonable, so if other windows user can test this and tell me it's useful for them, I'll be happy to merge it.

Thanks for your comments @philpep . I would get back to them asap!

tdas3001 commented 1 year ago

Thanks! Like I said in some other PR, I don't have knowledge neither time to maintain this. However this PR looks almost reasonable, so if other windows user can test this and tell me it's useful for them, I'll be happy to merge it.

Thanks for your comments @philpep . I would get back to them asap!

Hey @philpep . Just to let you know that I addressed your review comments. Thanks for having a look!

philpep commented 1 year ago

Merged, thanks!