search

pytest-dev / pytest-timeout

MIT License
216 stars 64 forks source link

add pre-commit config #47

Closed graingert closed 4 years ago

flub commented 4 years ago

Is there something in pre-commit like black for yaml files?

flub commented 4 years ago

Oh, lastly would you mind squashing the commits before merging?

graingert commented 4 years ago

Excuse my moaning about black's poor choices (double quotes? >79 lines? non-pep8? tssk!), I appreciate the benefit of this. Would be nice if you could address the few comments though.

E203 is non-pep8: https://github.com/PyCQA/pycodestyle/issues/373#issuecomment-393095146

graingert commented 4 years ago

Is there something in pre-commit like black for yaml files?

yes: https://github.com/adrienverge/yamllint I just went for what's in pytest-dev/pytest -mypy and with py2 compat