search

pytest-dev / pytest-timeout

MIT License
216 stars 64 forks source link

Get rid of the "py" module dependency #77

Closed zentarim closed 1 year ago

zentarim commented 4 years ago

The "py" module is now in maintenance mode and should not be used in new code. Moreover, only one method from the "py" module is used in the pytest-timeout. I suppose it is better to try to remove this dependency.

zentarim commented 4 years ago

Actually, I made a crude hack. I picked up these functions "as is" from the "py" codebase. Having a lot on my plate I can't dig deeper, but I hope I'll find some time to investigate and clean that hunk according to your demands. But I have a question: Do I need to maintain backward compatibility with Python2.7?

flub commented 4 years ago

On Sat 24 Oct 2020 at 09:33 -0700, zentarim wrote:

Do I need to maintain backward compatibility with Python2.7?

Hmm, given that pytest itself seems to have dropped this perhaps it's fine to remove python 2.7 support. So I won't reject matching the supported versions to pytest's own set of supported versions. Even if it makes me a little sad.

flub commented 4 years ago

Btw, do you know what pytest itself uses for this? I suspect the original intention was to use the same mechanism as pytest uses. If pytest migrated away from py and does this some other way the code here should probably do the same as pytest itself.

flub commented 1 year ago

Can this be accomplished now?

aqeelat commented 1 year ago

@flub this pr should no longer be needed since #116 got merged.

flub commented 1 year ago

@flub this pr should no longer be needed since #116 got merged.

ah, thanks for noticing. @aqeelat are you not able to close this yourself?

aqeelat commented 1 year ago

@flub I can, but I prefer to get confirmation from another maintainer before closing PRs.