Open larsoner opened 9 months ago
(Oh and it shouldn't be a 3.7 vs 3.8 thing because things were fine last week on these same runs!)
It looks like the conftest is not getting loaded since the data_path
also doesn't show up in the "available fixtures". This is probably related to annoying Windows path stuff.
I can probably reconstruct things from above but just to make things easier for me:
$TEST_PATH
in the example?Unrelated, but I'm curious: is there a reason you're doing this:
instead of making the fixture autouse=True
?
I can probably reconstruct things from above but just to make things easier for me:
From a new GHA run in a PR sandbox (where I could eventually test a fix branch if you want):
$TEST_PATH
is 'C:\Users\runneradmin\AppData\Local\Temp\cibw-run-iplgjl8i\cp39-win_amd64\venv-test\lib\site-packages\openmeeg'
pwd
(running in a bash script) is /c/Users/runneradmin/AppData/Local/Temp/cibw-run-iplgjl8i/cp39-win_amd64/test_cwd
C:\Users\runneradmin\AppData\Local\Temp\cibw-run-iplgjl8i\cp39-win_amd64\venv-test\lib\site-packages\openmeeg\tests\conftest.py
, found by pytest --fixtures $TEST_PATH
as ..\venv-test\lib\site-packages\openmeeg\tests\conftest.py
Unrelated, but I'm curious: is there a reason you're doing this:
Last year when I wrote this I didn't understand autouse=True
. Thanks for the reminder, I'll remove it!
@larsoner We've fixed some windows regressions, could you try again with latest main? I suspect it won't fix the issue but maybe it will.
Looks like on commit b510adf9efcd21e7ff2ab8e93e925f3e8363bb7d just now the failure is still there :disappointed:
OK, so keeping this on the radar, thanks for checking.
In this run:
https://github.com/openmeeg/openmeeg/actions/runs/7700673043/job/20985097864?pr=631#step:6:8200
You can see the 3.7 wheel work during testing (which uses 7.4.4), but fail in 3.8 testing (which uses 8.0.0). If I use
pytest --fixtures $TEST_PATH
the fixture is there:But when I run the tests with
pytest --tb=short -ra -m 'not slow' -vv $TEST_PATH
I get for all tests:Notably, this only happens on the Windows
cibuildwheel
run -- the Linux one in that same GHA is green. So the issue seems isolated to 8.0.0 on Windows. Nonetheless I am a bit mystified at whypytest --fixtures
seems to see a different set of fixtures compared to 7.4.4 :shrug:pip list
from the virtual environment you are usingNot sure how to make this one mimimal but I could put some time into this on my Windows VM at some point if it's not clear enough what's going on.