pytest-dev / pytest

The pytest framework makes it easy to write small tests, yet scales to support complex functional testing
https://pytest.org
MIT License
11.63k stars 2.58k forks source link

With 8.2.0, attempt to import docs from niece module fails #12276

Open jaraco opened 2 months ago

jaraco commented 2 months ago

This issue is perhaps one of the weirdest and most obscure I've seen. My investigation began in jaraco/jaraco.xonsh#1. The summary is this:

As you might imagine, creating a minimal example is near impossible given the peculiarities of this scenario. The jaraco.xonsh project is nearly a minimal example in itself. The easiest way to replicate the issue is to clone the project at 249226010f9c9e5490dab851947efba2dceecb63, install act, and run the command in https://github.com/jaraco/jaraco.xonsh/issues/1#issuecomment-2084576106.

Questions for which I'm hoping to find answers:

The-Compiler commented 2 months ago

What's new in pytest 8.2 that would trigger this behavior?

I somewhat painstakingly bisected this by using your act command and adjusting

diff --git i/pyproject.toml w/pyproject.toml
index ebdbf83..1fbe042 100644
--- i/pyproject.toml
+++ w/pyproject.toml
@@ -30,7 +30,7 @@ Homepage = "https://github.com/jaraco/jaraco.xonsh"
 [project.optional-dependencies]
 testing = [
    # upstream
-   "pytest >= 6, != 8.1.1",
+   "pytest @ git+https://github.com/pytest-dev/pytest@17fc20af78d0c7b739806c4e461d2c9b8c30ceeb",
    "pytest-checkdocs >= 2.4",
    "pytest-cov",
    "pytest-mypy",

accordingly.

This points me to 99890636bfd9bb156655050f22f1df47e74ac3f6, see: