Closed webknjaz closed 3 months ago
Hello @webknjaz,
From the warning, one fix is to replace functools.partial(check, i=2)
with staticmethod(functools.partial(check, i=2))
. But this is exactly what the next test case checks for.
Do we get rid of test_getfuncargnames_partial
entirely and rename test_getfuncargnames_staticmethod_partial
to test_getfuncargnames_partial
?
Dunno, but it seems like @Pierre-Sassoulas is about to do something about it..
Though, it'd be nice to submit that patch separately so that it could be backported easily.
Sure! The change mentioned skips the tests. I guess I'll submit a patch that does the same.
Feel free to cherry-pick or open another MR, I think the pre-commit tool update could be merged fast, but I didn't realize that python 3.13 need to be handled on backporting branches too.
@Pierre-Sassoulas FYI you never needed to fix the 3.13 problem as those jobs are not required to pass and don't block merging. There's a flaky pypy3 job, though, that might need to be restarted occasionally (the fix is in the works).
(https://github.com/pytest-dev/pytest/actions/runs/9745977844/job/26895224146#step:7:220)