Docs: Fix custom styling, restore bullets

pytest-dev / pytest

The pytest framework makes it easy to write small tests, yet scales to support complex functional testing

https://pytest.org

MIT License

11.68k stars 2.6k forks source link

Docs: Fix custom styling, restore bullets #12581

Open ferdnyc opened 2 weeks ago

ferdnyc commented 2 weeks ago

Move the custom CSS to a dedicated pytest.css file in _static/, and reference it from the configuraton's html_css_files list.
Update the list-customization styling to only affect .sidebar-scroll (the navigation sidebar), so that bullets are visible in the rest of the documentation.
Remove the list indent from the navigation sidebar, but only at the top level, so that navigation is still nested with visible indents.

Fixes #12573 Fixes #12576 Closes #12575 Updates #12290 Updates #12326

Before

After

ferdnyc commented 2 weeks ago

I added an additional commit with a small style fix, as IMHO this looks extremely unfortunate:

With the added margin it becomes this, which is perfect:

pradyunsg commented 1 week ago

I'm only now noticing the completely custom sidebar in pytest's documentation. I'll file a separate issue/PR about that, I guess.

pradyunsg commented 1 week ago

I've filed https://github.com/pytest-dev/pytest/pull/12584 for that.

pradyunsg commented 1 week ago

FWIW, I don't consider my PR to be "competing" with this one and have no concerns with this landing -- I'm happy to rebase mine once this one goes through. I realise that might not have been clear with my previous two comments. 😅

nicoddemus commented 1 week ago

Sorry I'm not keen on all the details so I must ask: @pradyunsg in your opinion is this PR ready to merge?