search

pytest-dev / pytest

The pytest framework makes it easy to write small tests, yet scales to support complex functional testing
https://pytest.org
MIT License
11.64k stars 2.58k forks source link

review/enhance behavioural consistency of the id generation process #4742

Open RonnyPfannschmidt opened 5 years ago

RonnyPfannschmidt commented 5 years ago

in #4740 we noted that there was a slight behavioral inconsistency in how we generate ids and how values are passed around in between real ids, the idfn, the id generation hook,

we kept the original behavior, but we really need a corrected outline on the behavior

im proposing this for pytest 6.0 as the correction may have the unwanted consequence of changing some test ids due to now passing trough the hook always

another outcome may be to iron out the cases where the call order should be as it is, and specifying it + tightening that contract with unit-tests

nicoddemus commented 4 years ago

@RonnyPfannschmidt you still want to tackle this for 6.0?

nicoddemus commented 3 years ago

@RonnyPfannschmidt gentle ping. Do you think you will be able to tackle this soon?

RonnyPfannschmidt commented 3 years ago

Unfortunately not within the next month

nicoddemus commented 3 years ago

OK no problem, thanks. I've removed it from the 6.1 milestone then, I don't think it is urgent for that release. Feel free to reschedule it to another version if you would like.