Space-containing parameters to custom options mess with rootdir

[tucked]

• [x] a detailed description of the bug or suggestion

If a custom option is defined in a conftest.py that is more than 1 directory below $PWD, that option is not discovered if the parameter to that option contains a space.

• [x] output of pip list from the virtual environment you are using

attrs (19.3.0)
importlib-metadata (1.6.1)
more-itertools (8.4.0)
packaging (20.4)
pip (9.0.1)
pkg-resources (0.0.0)
pluggy (0.13.1)
py (1.8.2)
pyparsing (2.4.7)
pytest (5.4.3)
setuptools (39.0.1)
six (1.15.0)
wcwidth (0.2.4)
zipp (3.1.0)

• [x] pytest and operating system versions

$ venv/bin/pytest --version
This is pytest version 5.4.3, imported from /tmp/tmp.iNSbiDWuuE/venv/lib/python3.6/site-packages/pytest/__init__.py

• This was originally reproduced with Python 2.7.15+ and pytest 4.6.11.

  $ lsb_release -a
  No LSB modules are available.
  Distributor ID: Ubuntu
  Description:    Ubuntu 18.04.3 LTS
  Release:        18.04
  Codename:       bionic

• [x] minimal example if possible

$ tree -a
.
└── path
    └── to
        └── some
            └── tests
                ├── conftest.py
                └── test_fail.py

4 directories, 2 files

$ cat path/to/some/tests/conftest.py
def pytest_addoption(parser):
    parser.addoption(
        "--foo",
        action="store",
        required=True,
        help="ya know, foo!",
    )
    parser.addoption(
        "--bar",
        action="store",
        required=True,
        help="ya know, bar!",
    )

$ cat path/to/some/tests/test_fail.py
import pytest

def test_foo(pytestconfig):
    pass

• Note: test_fail.py is a misnomer. The test will pass.

  $ python3 -m venv venv
  $ venv/bin/python -m pip install pytest
  ...
  Successfully installed attrs-19.3.0 importlib-metadata-1.6.1 more-itertools-8.4.0 packaging-20.4 pluggy-0.13.1 py-1.8.2 pyparsing-2.4.7 pytest-5.4.3 six-1.15.0 wcwidth-0.2.4 zipp-3.1.0

  
  $ venv/bin/pytest --foo=whatever --bar=baz path/to/some/tests/
  ========================================================= test session starts =========================================================
  platform linux -- Python 3.6.8, pytest-5.4.3, py-1.8.2, pluggy-0.13.1
  rootdir: /tmp/tmp.iNSbiDWuuE
  collected 1 item

path/to/some/tests/test_fail.py . [100%]

========================================================== 1 passed in 0.01s ==========================================================

- Great!

$ venv/bin/pytest --foo="what ever" --bar=baz path/to/some/tests/ ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...] pytest: error: unrecognized arguments: --bar=baz path/to/some/tests/ inifile: None rootdir: /tmp/tmp.iNSbiDWuuE

- Note: The only difference is `--foo="what ever"` instead of `--foo=whatever`.

$ mv path/to/some/tests/ . $ venv/bin/pytest --foo="what ever" --bar=baz tests/ ========================================================= test session starts =========================================================platform linux -- Python 3.6.8, pytest-5.4.3, py-1.8.2, pluggy-0.13.1 rootdir: /tmp/tmp.iNSbiDWuuE collected 1 item

tests/test_fail.py . [100%]

========================================================== 1 passed in 0.01s ==========================================================

- wat

[tucked]

The example does not seem to repro without the second custom option (i.e. --bar).

[asottile]

I cannot reproduce using your example

[tucked]

I can still reproduce with pytest 5.4.3 and 6.2.5 (on py36 and py39).

[asottile]

can you share a git repo or zip? what shell are you using?

[tucked]

Try this: https://github.com/tucked/pytest-7380

Shell is Bash 4.4.20(1)-release

[asottile]

seems pytest is detecting the --foo argument as the test collection root instead of treating it as an unknown argument in the initial argument parsing -- this prevents it from finding your deep conftest file (pytest path also skips the conftest)