search

pytest-dev / pytest

The pytest framework makes it easy to write small tests, yet scales to support complex functional testing
https://pytest.org
MIT License
11.68k stars 2.6k forks source link

Rerun failed tests broken in 5.4.3 #7508

Closed throwable-one closed 4 years ago

throwable-one commented 4 years ago 
from unittest import TestCase

def test_test():
    assert False

class FooTest(TestCase):
    def test_test(self):
        self.fail()

Run pytest. Two tests should fail. Run with --last-failed. Only one test launched. Try latest 5.3: it works as expected

The-Compiler commented 4 years ago

Bisected to 1b30514783d8ed4225a59af3f9f3fa668ab56f67 ("LFPlugin: use sub-plugins to deselect during collection (#6448)") which is a fix for #5301 - cc @blueyed

blueyed commented 4 years ago

Likely fixed by https://github.com/pytest-dev/pytest/pull/6991, was not backported (https://github.com/pytest-dev/pytest/pull/7219).

The-Compiler commented 4 years ago

Indeed fixed via #6991 in master already - sorry, I missed that! Closing this then.