search

pytest-dev / pytest

The pytest framework makes it easy to write small tests, yet scales to support complex functional testing
https://pytest.org
MIT License
12.07k stars 2.67k forks source link

Codecov bash uploader is deprecated #9202

Closed bluetech closed 3 years ago

bluetech commented 3 years ago

The Codecov bash uploader that the CI is using is deprecated and will stop working on Feb 1, 2022, with brownouts before then.

https://about.codecov.io/blog/introducing-codecovs-new-uploader/

We should update to their new uploader.

The relevant file is https://github.com/pytest-dev/pytest/blob/5fc7b21391c959bb5a54174d9084ad55131b8fdb/scripts/upload-coverage.sh

Called in CI from here: https://github.com/pytest-dev/pytest/blob/5fc7b21391c959bb5a54174d9084ad55131b8fdb/.github/workflows/main.yml#L168-L172

Note: the scripts/upload-coverage.sh script itself can stay in bash; just the codecov file it downloads should be changed to the new one.

RonnyPfannschmidt commented 3 years ago

should we use https://github.com/marketplace/actions/codecov while we are at it?

bluetech commented 3 years ago

Correct me if I'm wrong, but I don't think it will make the upload-coverage.sh redundant, since still need to do the python -m coverage xml step. So maybe it's not worth it...

cristianMeli commented 3 years ago

Hi there! Today I signed up at Hackertoberfest, I think that I could take this issue as my first contribution. What do you think @bluetech @RonnyPfannschmidt ?

bluetech commented 3 years ago

@cristianMeli Please do!

mPandaRed commented 3 years ago

Is this upload-coverage.sh file only being used in the GitHub action? If so, it looks like there is a pre-built Action created for Codecov V2: https://github.com/marketplace/actions/codecov

The upload-coverage.sh file could be completely replaced by just the Action