search

pytest-dev / pytest

The pytest framework makes it easy to write small tests, yet scales to support complex functional testing
https://pytest.org
MIT License
12.06k stars 2.67k forks source link

Review old "needs backport" PRs #9384

Open The-Compiler opened 2 years ago

The-Compiler commented 2 years ago

Looks like we have 35 old PRs with a "needs backport" label:

https://github.com/pytest-dev/pytest/pulls?q=is%3Apr+is%3Aclosed+label%3A%22needs+backport%22

Can we remove that, so we can use the label as a kind of "todo list" in the future still? What about the "backported" label, is that needed really?

nicoddemus commented 2 years ago

Can we remove that, so we can use the label as a kind of "todo list" in the future still?

Sure, we probably just forgot to remove them after backporting.

What about the "backported" label, is that needed really?

It serves as a marker that a PR was actually backported; just removing the needs backport label leaves the situation ambiguous, because we don't know if a PR has been backported or we forgot to do it entirely.