Closed jdufresne closed 5 years ago
Thanks for this pull-request. May I ask you to split this into 3 commits, as this pull-request actually contains 3 distinct changes:
To split the commit, git gui
is IMHO very useful).
When updating a pull-request, you can simply (force) push the updated branch to github again. This will automatically update the pull-request (which follows the branch, not the commit). So you do not need to close the pull-request and open a new one. This also has the benefit that the discussion history is kept.
Done! Ready for additional feedback.
I decided to swap the order of 2 & 3 as the Travis changes will fail without first doing the parameterize fixes.
Thanks! :slightly_smiling_face:
Thanks for the pull-request and sorry for not merging earlier.
Use 'dist: xenial' in Travis to as Travis's trusty doesn't support Python 3.7. This required dropping Python 3.3 support as xenial doesn't support Python 3.3. However, Python 3.3 is endo of life. It is no longer receiving bug fixes, including for security issues. It went EOL on 2017-09-29. pytest also does not support Python 3.3.
Required updating the use of pytest.mark.parametrize to avoid deprecated, removed features:
https://docs.pytest.org/en/latest/changelog.html#pytest-4-1-0-2019-01-05