Support aggregation in validator

pyth-network / pyth-client

Client API for on-chain pyth programs

https://pyth.network

Apache License 2.0

169 stars 102 forks source link

Support aggregation in validator #410

Closed Riateche closed 2 months ago

Riateche commented 3 months ago

Change dependency versions to make the crate compatible with pythnet validator
Add flags to price account to track transition from v1 to v2
Implement transition between v1 and v2 by calling add_publisher with a special pubkey
Skip aggregation and message buffer update in the oracle program if v2 aggregation is enabled
Clear message buffers after transition to v2
Expose aggregation as a library function to be used in the validator

guibescos commented 3 months ago

I think there might be an edgecase where the price stops aggregating (both v1 and v2). In a given slot:

upd_price : aggregation is unsuccessful therefore message_sent_ == 1
flags gets activated
aggregation v2 fails with V1AggregationMode since PriceAccountFlags::MESSAGE_BUFFER_CLEARED is false

Next slot:

upd_price no longer triggers an aggregation because PriceAccountFlags::ACCUMULATOR_V2 is true
aggregation v2 also fails since PriceAccountFlags::MESSAGE_BUFFER_CLEARED is false

And so on... let me know if you agree

Riateche commented 2 months ago

I think there might be an edgecase where the price stops aggregating (both v1 and v2).

Good catch! I've changed the code so that the MESSAGE_BUFFER_CLEARED is set regardless of the message_sent_ flag. I think this should fix the issue.